Add runtime operations in WFE#59966
Open
salmart-dev wants to merge 1 commit intomasterfrom
Open
Conversation
salmart-dev
force-pushed
the
feature/workflow-app-rules
branch
3 times, most recently
from
7eff7fc to
d19fe62
Compare
salmart-dev
changed the title
salmart-dev
force-pushed
the
feature/workflow-app-rules
branch
2 times, most recently
from
b8030e7 to
07960ec
Compare
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com> # Conflicts: # apps/workflowengine/lib/Manager.php
salmart-dev
force-pushed
the
feature/workflow-app-rules
branch
from
07960ec to
5741066
Compare
salmart-dev
requested review from
a team,
blizzz,
juliusknorr and
nickvergessen
as code owners
salmart-dev
requested review from
ArtificialOwl,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
| * @param class-string<IEntity> $entity | ||
| * @param list<class-string<IEntityEvent>> $events | ||
| */ | ||
| public function addRuntimeOperation( |
Member
There was a problem hiding this comment.
Those public methods should be in OCP?
Contributor
Author
There was a problem hiding this comment.
Since I'm not sure that this fully satisfies what's needed to have fully working runtime operations, I didn't add those changes publicly as I would consider them "unstable".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces runtime operations to the Workflow Engine
Sometimes apps may want to hook into the WFE event/check pipeline without surfacing those flows to administrators or users. Classic WFE operations are stored in the DB and fully visible and editable via the UI. Runtime operations fill the gap for programmatically defined, app-internal flows.
Registration flow
At boot, the WFE application dispatches
RegisterRuntimeOperationsEvent(note it's internal) beforeregisterRuleListenersruns. Internal apps can listen to this event and callManager::addRuntimeOperation()as needed.Checklist
3. to review, feature component)stable32)AI (if applicable)